Skip to content

Fix record of new_episodes mode #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix record of new_episodes mode #755

wants to merge 3 commits into from

Conversation

@vickyliin
Copy link

@vickyliin vickyliin commented Aug 3, 2023 •
edited
Loading

Fix #753

I found play_count is heavily relied on in the tests to check if a record is newly added or being played.

I'm wondering if

  • I should modify the logic of play_count to be added whenever a record has been played no matter from loaded cassettes or from a real request (like the change in this PR now) and change all the related tests
  • or I should find a work around

@vickyliin vickyliin marked this pull request as ready for review August 7, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CORE BUG][Verified Can Replicate] Wrong number of requests recorded under new_episodes mode

1 participant

@vickyliin